Rescope Logger::Levels enum so it can be moved to envoy/ directory - #46668
Merged
Conversation
yanavlasov
force-pushed
the
rescope-logger-enum
branch
4 times, most recently
from
August 12, 2026 20:55
ca0a77e to
de613df
Compare
Signed-off-by: Yan Avlasov <yavlasov@google.com>
yanavlasov
force-pushed
the
rescope-logger-enum
branch
from
August 12, 2026 21:12
de613df to
fbdd751
Compare
Signed-off-by: Yan Avlasov <yavlasov@google.com>
yanavlasov
marked this pull request as ready for review
August 12, 2026 21:48
yanavlasov
requested review from
KBaichoo,
RyanTheOptimist,
abeyad and
danzh2010
as code owners
August 12, 2026 21:48
yanavlasov
enabled auto-merge (squash)
August 12, 2026 21:49
yanavlasov
changed the title
agrawroh
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main change is in the source/common/common/base_logger.h, moving the Levels enum out of the Logger class into the outer Logger namespace.
This is intermediate step to using this enum in Envoy's interfaces in the envoy/ directory. This will prevent leaking of the spdlog dependency to proprietary components that need to manipulate Envoy's log level programmatically.
Risk Level: low
Testing: unit tests
Docs Changes: no
Release Notes: no
Platform Specific Features: no